test: fix mismatched tls.key in tlsroute dynamic resolver testdata - #9582
Merged
arkodg merged 1 commit intoJul 26, 2026
Merged
Conversation
The tls-secret-1 added in envoyproxy#9184 for tlsroute-dynamic-resolver-with-tls-terminate.in.yaml carries a tls.key that does not match its tls.crt, so the secret fails validation: No valid secrets exist: envoy-gateway/tls-secret-1 must contain a matching tls.crt and tls.key: tls: private key does not match public key. As a result the listener is never programmed, it is dropped from both infraIR and xdsIR, and the TLSRoute reports ResolvedRefs=True instead of the intended "Dynamic resolver backend is only supported with TLS passthrough listeners" error. The test therefore no longer exercises the dynamic resolver + TLS terminate path it was written for, and gen-check fails on main because the committed .out.yaml does not match what the translator now produces. Replace tls.key with the key that actually matches tls.crt, the same one used by the other 24 testdata files sharing this certificate. The committed .out.yaml is correct as-is and is left unchanged. Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9582 +/- ##
==========================================
- Coverage 75.64% 75.64% -0.01%
==========================================
Files 252 253 +1
Lines 41758 41836 +78
==========================================
+ Hits 31589 31645 +56
- Misses 8046 8061 +15
- Partials 2123 2130 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arkodg
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen-checkis currently failing onmain. Thetls-secret-1added in #9184 fortlsroute-dynamic-resolver-with-tls-terminate.in.yamlhas a outdatedtls.keythat doesn't match itstls.crt: